fix invalid pod_id persistence in exec session#475
Open
vivienhenz24 wants to merge 1 commit intorunpod:mainfrom
Open
fix invalid pod_id persistence in exec session#475vivienhenz24 wants to merge 1 commit intorunpod:mainfrom
vivienhenz24 wants to merge 1 commit intorunpod:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a gap in get_session_pod() where a user-entered pod ID was previously persisted to ~/.runpod/pod_id without validation, leading to stale/typo’d IDs being saved and causing repeated prompts on later runs.
Changes:
- Validate a prompted pod ID via
get_pod()before writing it to~/.runpod/pod_id. - Raise a CLI-facing error when the prompted pod ID is invalid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # If file doesn't exist or is empty, prompt user for the pod_id | ||
| pod_id = click.prompt("Please provide the pod ID") | ||
| if get_pod(pod_id) is None: | ||
| raise click.ClickException("Invalid pod ID.") |
Comment on lines
32
to
37
| pod_id = click.prompt("Please provide the pod ID") | ||
| if get_pod(pod_id) is None: | ||
| raise click.ClickException("Invalid pod ID.") | ||
| os.makedirs(os.path.dirname(POD_ID_FILE), exist_ok=True) | ||
| with open(POD_ID_FILE, "w", encoding="UTF-8") as pod_file: | ||
| pod_file.write(pod_id) |
Comment on lines
+33
to
+34
| if get_pod(pod_id) is None: | ||
| raise click.ClickException("Invalid pod ID.") |
| @@ -30,6 +30,8 @@ def get_session_pod(): | |||
|
|
|||
| # If file doesn't exist or is empty, prompt user for the pod_id | |||
| pod_id = click.prompt("Please provide the pod ID") | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other bug: found a gap in get_session_pod() where a user‑entered pod id is never validated before being written to ~/.runpod/pod_id. So that lets typos/stale ids get persisted on later runs, which then forces repeated prompts. Basically stored ids were validated but prompted ones were not.
I added a small validation check to fix